Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rustc integration setup #232

Closed
matprec opened this issue Jun 2, 2020 · 3 comments · Fixed by #233
Closed

Rustc integration setup #232

matprec opened this issue Jun 2, 2020 · 3 comments · Fixed by #233

Comments

@matprec
Copy link

matprec commented Jun 2, 2020

The current rustc integration setup is strictly speaking not conforming with the cargo rule, that features are additive. LSP implementations like rust-analyzer assume that crates strictly adhere to that rule and compile/check with --all-features by default, which breaks because of the rustc-dep-of-std feature. This causes issues like rust-lang/rust-analyzer#4702.

I can't think of an elegant solution for this problem, but maybe something along the lines of explicitly failing with compile_error! and a helpful message would make this more discoverable.

@philipc
Copy link
Contributor

philipc commented Jun 2, 2020

@alexcrichton Do you have any ideas about what to do for this?

@philipc
Copy link
Contributor

philipc commented Jun 2, 2020

#233 is the best I could come up with.

@alexcrichton
Copy link
Contributor

Yeah unfortunately I don't know of a great way to solve this. The root of the issue is the weirdness of getting built as part of libstd. I'd love to fix that but I don't really know of another way myself.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants