Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: 3D Fmajor/Fminor are flipped. #3

Closed
l-espana opened this issue Dec 18, 2023 · 9 comments
Closed

BUG: 3D Fmajor/Fminor are flipped. #3

l-espana opened this issue Dec 18, 2023 · 9 comments
Labels
bug Something isn't working

Comments

@l-espana
Copy link

Hi,

Not sure if this project is being maintained, but we've noticed the in the tracula_3d atlas the Fmajor and Fminor geometries appear to be flipped. Not sure of the best way to implement a fix.

@drmowinckels
Copy link
Contributor

Hi!

when you say flipped, you mean the labels are swapped or that the actual geometries are incorrectly placed?

@l-espana
Copy link
Author

l-espana commented Jan 3, 2024

Hello!
The actual geometries are incorrect. The one labeled Fmajor is actually Fminor and vice versa.

@drmowinckels
Copy link
Contributor

ok. That's what i meant with the labels being incorrect. If the structure looks correct, but the label for the structure is incorrect, that is a very easy thing to fix. And I'll get to that asap.

@drmowinckels drmowinckels added the bug Something isn't working label Jan 3, 2024
@drmowinckels
Copy link
Contributor

Hi. Looking into this, the labels are correct as I see them. The forceps minor connecting the frontal lobes (https://radiopaedia.org/articles/forceps-minor), and the frceps major connecting the occipital lobes (https://radiopaedia.org/articles/forceps-major).

image

@l-espana
Copy link
Author

l-espana commented Jan 3, 2024

Yes, so in the 2d version it's fine. If you plot in 3d the geometries are in the wrong location.

@drmowinckels
Copy link
Contributor

ok, that soooo weird. Sorry for not catching you meant 3d! Good catch.

Screenshot 2024-01-03 at 14 02 24

@l-espana
Copy link
Author

l-espana commented Jan 3, 2024

Yes! My PI figured it out...took us a while to understand what was going on ha.

drmowinckels added a commit that referenced this issue Jan 3, 2024
@drmowinckels
Copy link
Contributor

The fix has been implemented, let me know how that works for you! it's gonna take a couple of hours for the R-Universe to have the new version built an ready.

Once This page shows version 1.0.1.002 then the new version is ready to be installed and you can test with:

# Enable this universe
options(repos = c(
    ggseg = 'https://ggseg.r-universe.dev',
    CRAN = 'https://cloud.r-project.org'))

# Install some packages
install.packages('ggsegTracula')

@l-espana
Copy link
Author

Looks great! Thanks for the fix!!! (Sorry, thought I responded ages ago, ha).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants