Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Latest release wont compile (ggml.c) #1120

Closed
klosax opened this issue Apr 22, 2023 · 5 comments · Fixed by #1154
Closed

Latest release wont compile (ggml.c) #1120

klosax opened this issue Apr 22, 2023 · 5 comments · Fixed by #1154

Comments

@klosax
Copy link
Collaborator

klosax commented Apr 22, 2023

Release: master-36b4f7e

ggml.c: In function ‘bytes_from_nibbles_16’:
ggml.c:439:19: warning: implicit declaration of function ‘_mm_loadu_si64’; did you mean ‘_mm_loadl_epi64’? [-Wimplicit-function-declaration]

 __m128i tmp = _mm_loadu_si64( ( const __m128i* )rsi );
               ^~~~~~~~~~~~~~
               _mm_loadl_epi64

ggml.c:439:19: error: incompatible types when initializing type ‘__m128i’ {aka ‘__vector(2) long long int’} using type ‘int’

Using:
cc (Ubuntu 8.4.0-3ubuntu2) 8.4.0
g++ (Ubuntu 8.4.0-3ubuntu2) 8.4.0

@sw
Copy link
Collaborator

sw commented Apr 22, 2023

Try with a more recent version of gcc, 8.4 is 3 years old by now.

9.0 should fix this: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=78782

@klosax
Copy link
Collaborator Author

klosax commented Apr 22, 2023

That worked. Thank you.

@prusnak
Copy link
Collaborator

prusnak commented Apr 23, 2023

ggml issue: ggerganov/ggml#99

@sw
Copy link
Collaborator

sw commented Apr 24, 2023

Reopening as there seems to be an easy fix to stay compatible with gcc 8: ggerganov/ggml#99 (comment)

@cabelo
Copy link

cabelo commented Feb 20, 2024

@klosax , This PR #5606 works well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants