Pull requesting review etiquette #1566
Unanswered
KerfuffleV2
asked this question in
Q&A
Replies: 1 comment
-
you can request me when its cmake, github ci or maybe c++. |
Beta Was this translation helpful? Give feedback.
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
When you create a pull request, GitHub's interface suggests several people that could be requested to review it. Is it a good idea/polite to actually use that, or is it better to just wait for someone to see the pull and deal with it "naturally"?
I haven't used that feature so far, because it feels like it could seem like saying "Hey, deal with my pull right now!" Presumably the people who want to review pull requests will check the list of recent new pull requests periodically when they have time and don't need to be reminded but perhaps that assumption is incorrect.
Thanks for reading.
Beta Was this translation helpful? Give feedback.
All reactions