Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there is a bug in
ggml_conv_2d
which mixed up convolution results from different images when run in batch mode.Specifically, this line
is supposed to reshape result to [N, OC, OH, OW]. However, values for a particular
i
of dimension N (batch size) are mixed fromj's
.This can be checked by making a stack of 2 input images each with identical but different values and observe the convolution mixed from both images.
The proper way to do this step is