From d174d20a094d2147ea2988f284e6d5c54a3da606 Mon Sep 17 00:00:00 2001 From: Elabajaba Date: Tue, 5 Jul 2022 15:24:49 -0400 Subject: [PATCH 1/3] space PresentMode no longer automatically falls back to Fifo --- wgpu-types/src/lib.rs | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/wgpu-types/src/lib.rs b/wgpu-types/src/lib.rs index 26677729b8..00406564d9 100644 --- a/wgpu-types/src/lib.rs +++ b/wgpu-types/src/lib.rs @@ -2994,7 +2994,7 @@ pub enum PresentMode { /// /// Tearing can be observed. /// - /// Supported on most platforms except older DX12. + /// Supported on most platforms except older DX12 and Wayland. /// /// This is traditionally called "Vsync Off". Immediate = 4, @@ -3065,8 +3065,10 @@ pub struct SurfaceConfiguration { pub width: u32, /// Height of the swap chain. Must be the same size as the surface. pub height: u32, - /// Presentation mode of the swap chain. FIFO is the only guaranteed to be supported, though - /// other formats will automatically fall back to FIFO. + /// Presentation mode of the swap chain. Fifo is the only mode guaranteed to be supported. + /// FifoRelaxed, Immediate, and Mailbox will crash if unsupported, while AutoVsync and + /// AutoNoVsync will gracefully fall back to Fifo without crashing if their primary modes are + /// unsupported. pub present_mode: PresentMode, } From 5e27d0fbba030777ac9801097bdc129a705eba23 Mon Sep 17 00:00:00 2001 From: Elabajaba Date: Tue, 5 Jul 2022 16:18:30 -0400 Subject: [PATCH 2/3] Update wgpu-types/src/lib.rs Auto(No)Vsync fallback wording. Co-authored-by: Connor Fitzgerald --- wgpu-types/src/lib.rs | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/wgpu-types/src/lib.rs b/wgpu-types/src/lib.rs index 00406564d9..be804147d2 100644 --- a/wgpu-types/src/lib.rs +++ b/wgpu-types/src/lib.rs @@ -3067,7 +3067,7 @@ pub struct SurfaceConfiguration { pub height: u32, /// Presentation mode of the swap chain. Fifo is the only mode guaranteed to be supported. /// FifoRelaxed, Immediate, and Mailbox will crash if unsupported, while AutoVsync and - /// AutoNoVsync will gracefully fall back to Fifo without crashing if their primary modes are + /// AutoNoVsync will gracefully do a designed sets of fallbacks if their primary modes are /// unsupported. pub present_mode: PresentMode, } From 819a8884cc36ecb811e3da002949938036b0f4d9 Mon Sep 17 00:00:00 2001 From: Elabajaba Date: Tue, 5 Jul 2022 16:43:51 -0400 Subject: [PATCH 3/3] changelog --- CHANGELOG.md | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/CHANGELOG.md b/CHANGELOG.md index 9b0dd96480..1c71c9da01 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -45,6 +45,11 @@ Bottom level categories: #### DX12 - `DownlevelCapabilities::default()` now returns the `ANISOTROPIC_FILTERING` flag set to true so DX12 lists `ANISOTROPIC_FILTERING` as true again by @cwfitzgerald in [#2851](https://github.com/gfx-rs/wgpu/pull/2851) +### Documentation + +- Update present_mode docs as most of them don't automatically fall back to Fifo anymore. by @Elabajaba in [#2855](https://github.com/gfx-rs/wgpu/pull/2855) + + ## wgpu-0.13.1 (2022-07-02) ### Bug Fixes