Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

static-dxc Doesn't Support aarch64 #6860

Closed
tronical opened this issue Jan 5, 2025 · 4 comments · Fixed by #6868
Closed

static-dxc Doesn't Support aarch64 #6860

tronical opened this issue Jan 5, 2025 · 4 comments · Fixed by #6868
Labels
backend: dx12 Issues with DX12 or DXGI platform: windows Issues with integration with windows type: bug Something isn't working

Comments

@tronical
Copy link

tronical commented Jan 5, 2025

Description

Compling for Windows ARM (aarch64-windows-msvc) doesn't work.

Repro steps

cargo build in the wgpu repo reproduces this easily.

Expected vs observed behavior

error: failed to run custom build command for `mach-dxcompiler-rs v0.1.4+2024.11.22-df583a3.1`

Caused by:
  process didn't exit successfully: `C:\dev\wgpu\target\debug\build\mach-dxcompiler-rs-e93f55e2962306f4\build-script-build` (exit code: 101)
  --- stdout
  cargo:rerun-if-changed=msvc_version.c
  cargo:rerun-if-changed=mach_dxc.h

  --- stderr
  thread 'main' panicked at c:\cargo_home\registry\src\index.crates.io-6f17d22bba15001f\mach-dxcompiler-rs-0.1.4+2024.11.22-df583a3.1\build.rs:119:9:
  Unsupported target: aarch64-windows-msvc
  Check supported targets on https://github.com/DouglasDwyer/mach-dxcompiler/releases
  note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
warning: build failed, waiting for other jobs to finish...

Platform

Windows-ARM

@cwfitzgerald
Copy link
Member

Gah should probably add this to ci.

@cwfitzgerald
Copy link
Member

@DouglasDwyer is aarch64 windows support possible? Otherwise we can prevent static-dxc from being available on aarch64.

@cwfitzgerald cwfitzgerald added type: bug Something isn't working backend: dx12 Issues with DX12 or DXGI platform: windows Issues with integration with windows labels Jan 6, 2025
@DouglasDwyer
Copy link
Contributor

@DouglasDwyer is aarch64 windows support possible? Otherwise we can prevent static-dxc from being available on aarch64.

When I try to build the mach-dxcompiler project for aarch64, I get a bunch of link errors: error: lld-link: libucrtd.lib(exit.obj): machine type x64 conflicts with arm64. It seems that Zig's build system is trying to link the x86 C runtime libraries with the Arm binary. Unfortunately, I don't know enough about cross-compiling for Arm on Windows right now - and GitHub CI does not support aarch64 Windows runners so I can't use one to build the binary natively. As such, I don't plan to work on aarch64 Windows support in the near future - sorry. As an alternative, the aarch64-windows-gnu target is supported.

@cwfitzgerald
Copy link
Member

Alright, we'll fix this on our side

@cwfitzgerald cwfitzgerald changed the title aarch64-windows-msvc build is broken static-dxc Doesn't Support aarch64 Jan 6, 2025
@github-project-automation github-project-automation bot moved this from Todo to Done in WebGPU for Firefox Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend: dx12 Issues with DX12 or DXGI platform: windows Issues with integration with windows type: bug Something isn't working
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants