Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep pipeline layouts alive #580

Closed
kvark opened this issue Apr 14, 2020 · 2 comments · Fixed by #582
Closed

Keep pipeline layouts alive #580

kvark opened this issue Apr 14, 2020 · 2 comments · Fixed by #582
Labels
type: bug Something isn't working

Comments

@kvark
Copy link
Member

kvark commented Apr 14, 2020

We currently allow the user to drop them. However, pipelines still need to consider their layouts when used, same goes for bind group layouts. The difference, I suppose, is that bind group layout IDs are not accessed ever, just compared.

Perhaps, we could get away by simply storing the contents of pipeline layouts within our pipelines?

@kvark kvark added the type: bug Something isn't working label Apr 14, 2020
@grovesNL
Copy link
Collaborator

The difference, I suppose, is that bind group layout IDs are not accessed ever, just compared.

Won't this change once we fix #335?

@kvark
Copy link
Member Author

kvark commented Apr 14, 2020

@grovesNL it depends... We may implement it as bind groups are created separately and compared by value. OR, we can track bind group layouts in the same style as we do pipeline layouts, and just return a reference to an existing object when the user creates a new one. This second choice seems better to me, on the surface.

@bors bors bot closed this as completed in 729ecb1 Apr 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants