Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement WGSL uniformity analysis #4369

Open
jimblandy opened this issue Feb 23, 2022 · 1 comment
Open

Implement WGSL uniformity analysis #4369

jimblandy opened this issue Feb 23, 2022 · 1 comment
Labels
area: validation Issues related to validation, diagnostics, and error handling naga Shader Translator
Milestone
WebGPU Specificat...

Comments

@jimblandy
Copy link
Member

jimblandy commented Feb 23, 2022 •
edited by teoxoy
Loading

Naga should implement the uniformity analysis introduced in gpuweb/gpuweb@0561a0ee.

I think this would replace the uniformity analysis we have now. It could still be enabled by ValidationFlags::CONTROL_FLOW_UNIFORMITY.

The algorithm given in the spec looks, at first glance, like it should be straightforward to implement on Naga's IR, even though we don't have handles/indices for statements, only expressions.

There are also some more ideas on how to update our analysis in #4320.
@jimblandy jimblandy added the area: validation Issues related to validation, diagnostics, and error handling label Feb 23, 2022
@jimblandy jimblandy mentioned this issue May 9, 2023
Merged
@teoxoy teoxoy mentioned this issue Oct 23, 2023
Merged
@cwfitzgerald cwfitzgerald added the naga Shader Translator label Oct 25, 2023
@cwfitzgerald cwfitzgerald transferred this issue from gfx-rs/naga Oct 25, 2023
@teoxoy teoxoy mentioned this issue Dec 12, 2022
Closed
This was referenced Nov 3, 2023
Closed
Closed
Closed
Closed
Closed
@teoxoy teoxoy added this to the WebGPU Specification V1 milestone Nov 3, 2023
@jimblandy jimblandy moved this to Three weeks in WebGPU for Firefox Dec 12, 2023
@teoxoy teoxoy removed the status in WebGPU for Firefox Dec 14, 2023
@ErichDonGubler ErichDonGubler mentioned this issue Oct 3, 2024
Open
@ErichDonGubler
Copy link
Member

Firefox downstream tracking issue: https://bugzilla.mozilla.org/show_bug.cgi?id=1850044

@ErichDonGubler ErichDonGubler mentioned this issue Nov 12, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area: validation Issues related to validation, diagnostics, and error handling naga Shader Translator
Projects
WebGPU for Firefox
Status: No status
Milestone
WebGPU Specification V1
Development

No branches or pull requests
4 participants
@ErichDonGubler @jimblandy @cwfitzgerald @teoxoy