Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

On Vulkan, debug labels shouldn't require validation layer #3913

Closed
jimblandy opened this issue Jul 7, 2023 · 1 comment · Fixed by #5345
Closed

On Vulkan, debug labels shouldn't require validation layer #3913

jimblandy opened this issue Jul 7, 2023 · 1 comment · Fixed by #5345
Labels
api: vulkan Issues with Vulkan area: correctness We're behaving incorrectly area: validation Issues related to validation, diagnostics, and error handling type: bug Something isn't working

Comments

@jimblandy
Copy link
Member

jimblandy commented Jul 7, 2023 •
edited
Loading

In #3809, I unintentionally made the population of wgpu_hal::vulkan::InstanceShared::debug_utils conditional on both:

  • the availability of the VK_EXT_debug_utils extension and
  • the availability of the VK_LAYER_KHRONOS_validation.

It it perfectly possible to report debug labels even when validation is not enabled: the extension and the layer are independent of each other.
@jimblandy jimblandy added type: bug Something isn't working area: validation Issues related to validation, diagnostics, and error handling area: correctness We're behaving incorrectly api: vulkan Issues with Vulkan labels Jul 7, 2023
@kulkalkul
Copy link

If anyone else encounters this, InstaceFlags::VALIDATION is enabled when debugging but it still requires Vulkan Configurator installed (bundled in Vulkan SDK I think).

@DJMcNab DJMcNab mentioned this issue Mar 5, 2024
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
api: vulkan Issues with Vulkan area: correctness We're behaving incorrectly area: validation Issues related to validation, diagnostics, and error handling type: bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Don't depend on validation layers for setting object names DJMcNab/wgpu
2 participants
@jimblandy @kulkalkul