Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Limit 'max_storage_textures_per_shader_stage' value 4 is better than allowed 0' #1695

Closed
Gordon-F opened this issue Jul 20, 2021 · 2 comments · Fixed by #1732
Closed
Labels
type: bug Something isn't working

Comments

@Gordon-F
Copy link
Contributor

Description
Limit 'max_storage_textures_per_shader_stage' value 4 is better than allowed 0'.

Repro steps
Run examples on Android.

Extra materials
max_storage_textures_per_shader_stage on GL:

max_storage_textures_per_shader_stage: vertex_shader_storage_textures
                .min(fragment_shader_storage_textures),
[wgpu-hal/src/gles/adapter.rs:193] vertex_shader_storage_textures = 0
[wgpu-hal/src/gles/adapter.rs:193] fragment_shader_storage_textures = 8

Platform
Android 8.0 (Another device with 11.0), wgpu master.

@Gordon-F
Copy link
Contributor Author

Same for max_storage_buffers_per_shader_stage:

[wgpu-hal/src/gles/adapter.rs:207] vertex_shader_storage_blocks = 0
[wgpu-hal/src/gles/adapter.rs:208] fragment_shader_storage_blocks = 35

@kvark kvark added the type: bug Something isn't working label Jul 20, 2021
@kvark
Copy link
Member

kvark commented Jul 20, 2021

Thank you for filing! We need to change max_storage_textures_per_shader_stage computation to account for some of them could be zeroes (and it's already captured by other downlevel flags).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants