Mark the gfoidl.Analyzers dependency as a private asset

[ycrumeyrolle]

The gfoidl.Analyzers may generates a lots of undesired warnings when the package gfoidl.Base64 is in other projects.
On my project, this is generating 184 warnings :(
May be the attribute PrivateAssets on the package will fix the issue ?

[ycrumeyrolle]

Wondering if the same could be applyied to LocalsInit.Fody (is it a dev depedency?)

[gfoidl]

On my project, this is generating 184 warnings :(

Oh, this was not my intention. Sorry.

Wondering if the same could be applyied to LocalsInit.Fody (is it a dev depedency?)

Makes sense.

gfoidl.Analyzers

The purpose is that the "internal" encoders aren't access directly, they should be accessed via Base64.Default or Base64.Url.
To allow the JIT to devirtualize them, they need to be public.

I'll have a look on how to fix this. Maybe this analyzer should just look at the specific namespace, so any other code won't be considered.

Thanks for reporting!

[ycrumeyrolle]

Maybe this analyzer should just look at the specific namespace, so any other code won't be considered.

👍

[gfoidl]

Wondering if the same could be applyied to LocalsInit.Fody (is it a dev depedency?)

Interesting, it's already set:

Base64/source/gfoidl.Base64/gfoidl.Base64.csproj

Lines 31 to 34 in 2e2ebc9

	<PackageReference Include="Fody" Version="6.0.4">
	<PrivateAssets>all</PrivateAssets>
	<IncludeAssets>runtime; build; native; contentfiles; analyzers; buildtransitive</IncludeAssets>
	</PackageReference>

Is there something missing? Do you have any clue therefore?

[gfoidl]

To my last comment: That's Fody and not LocalsInit.Fody. So please ignore this comment.

[gfoidl]

The part for the analyzer is tracked in gfoidl/Analyzers#4