Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: make create project expiresAt null instead of empty string #939

Merged
merged 1 commit into from
Jun 9, 2023
Merged

fix: make create project expiresAt null instead of empty string #939

merged 1 commit into from
Jun 9, 2023

Conversation

jfrader
Copy link
Contributor

@jfrader jfrader commented Jun 8, 2023

Resolves GEY-2546

@linear
Copy link

linear bot commented Jun 8, 2023

GEY-2546 Empty string sent on expiresAt for project creation

GEY-2462

sajald77
sajald77 approved these changes Jun 9, 2023
View reviewed changes
Copy link
Collaborator

@sajald77 sajald77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but we might want to use undefined. As that's what we use for most of the cases.

@jfrader
Copy link
Contributor Author

jfrader commented Jun 9, 2023

@sajald77 looking into apollo studio it expects null

@jfrader jfrader merged commit ac8490a into staging Jun 9, 2023
@jfrader jfrader deleted the fran/gey-2546-empty-string-sent-on-expiresat-for-project-creation branch June 9, 2023 02:33
jfrader added a commit that referenced this pull request Jun 20, 2023
@jfrader
fix: make create project expiresAt null instead of empty string when …
c956d16 
…ongoing is selected (#939)
jfrader added a commit that referenced this pull request Jun 20, 2023
@jfrader
fix: make create project expiresAt null instead of empty string when …
613c356 
…ongoing is selected (#939)
jfrader added a commit that referenced this pull request Jun 20, 2023
@jfrader
fix: make create project expiresAt null instead of empty string when …
001c75d 
…ongoing is selected (#939)
jfrader added a commit that referenced this pull request Jun 20, 2023
@jfrader
fix: make create project expiresAt null instead of empty string when …
83bd9fe 
…ongoing is selected (#939)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sajald77 sajald77 sajald77 approved these changes

@steliosrammos steliosrammos Awaiting requested review from steliosrammos

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jfrader @sajald77