Allow funder to login from funding flow #859
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jfrader
changed the title
jfrader
commented
May 9, 2023
src/pages/projectView/projectMainBody/components/ProjectFundingFormCommentField.tsx
Show resolved
Hide resolved
|
If you are wondering why so many changes it's because the comment textarea has some performance issues, it's not as smooth as it should be when typing fast. It still needs to improve, my opinion is that we are passing the entire form state too deep through components and everything gets re-rendered from top to bottom each keystroke. I have another task created for hiding the user's identity while funding and will use that to make this better. |
jfrader
force-pushed
the
fran/gey-1721-allow-funder-to-login-from-funding-flow
branch
from
90d38db
to
682646a
Compare
sajald77
approved these changes
May 11, 2023
* refactor: make ProjectProvider avoid multiple network-only requests not needed * feat: add project navigation in left panel * chore: remove unused hook
sajald77
added a commit
that referenced
this pull request
May 12, 2023
* staging: feat: Allow funder to login from funding flow (#859)
jfrader
added a commit
that referenced
this pull request
May 15, 2023
* feat: add profile to comment box * fix: missing deps * chore: improve setTarget tn * feat: Implement the left sidebar (#864) * refactor: make ProjectProvider avoid multiple network-only requests not needed * feat: add project navigation in left panel * chore: remove unused hook
jfrader
added a commit
that referenced
this pull request
May 15, 2023
* feat: add profile to comment box * fix: missing deps * chore: improve setTarget tn * feat: Implement the left sidebar (#864) * refactor: make ProjectProvider avoid multiple network-only requests not needed * feat: add project navigation in left panel * chore: remove unused hook
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves GEY-1721