Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

path_regex doesn't normalize paths with filepath.ToSlash #1036

Open
tw1nk opened this issue Apr 1, 2022 · 1 comment · May be fixed by #1523
Open

path_regex doesn't normalize paths with filepath.ToSlash #1036

tw1nk opened this issue Apr 1, 2022 · 1 comment · May be fixed by #1523

Comments

@tw1nk
Copy link

tw1nk commented Apr 1, 2022

Currently to support path_regexes that should work on windows and other systems you need to manually handle the different separators with (/|\\) like this.

- path_regex: staging(/|\\).*\.secret\.(yaml|json)$
  gcp_kms: projects/.../sops-key-staging

This is a bit cumbersome and a bit error prone to use and would be nicer if we could just use slashes like this:

- path_regex: staging/.*\.secret\.(yaml|json)$
  gcp_kms: projects/.../sops-key-staging
@anperez-mms
Copy link

Is it possible to add a note in the README file to help Windows users to understand why path_regex is not working as expected?

@Prince213 Prince213 linked a pull request Jun 7, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: normalize path for creation rules Prince213/sops
2 participants
@tw1nk @anperez-mms