Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move TD/SA apps to low privilege account #65

Closed
Tracked by #37
chadwhitacre opened this issue Nov 7, 2022 · 13 comments
Closed
Tracked by #37

Move TD/SA apps to low privilege account #65

chadwhitacre opened this issue Nov 7, 2022 · 13 comments
Assignees

Comments

@chadwhitacre
Copy link
Member

chadwhitacre commented Nov 7, 2022

This is an action item out of the security review for #37.

@chadwhitacre chadwhitacre mentioned this issue Nov 7, 2022
44 tasks
@chadwhitacre chadwhitacre changed the title Vet apps/action for TD and SA in Jira. Move TD/SA apps to low privilege account Nov 7, 2022
@chadwhitacre
Copy link
Member Author

chadwhitacre commented Nov 8, 2022

From Jira:

Both apps are connected to my personal account (private links for my reference: TD, SA) in order to:

  • Verify my GitHub identity
  • Know what resources I can access
  • Act on my behalf
  • View my email addresses

The “Act on your behalf” is scary. Fortunately, it is limited by the app permissions specified:

It is also limited to the repos that the app is installed on. Both are installed on our Tier 1 repos (all public) + one more (sentry-go).

@chadwhitacre
Copy link
Member Author

chadwhitacre commented Nov 8, 2022

If I revoke access to my personal account, will the org install still work? 🤔


Screen Shot 2022-11-08 at 4 39 22 PM


Screen Shot 2022-11-08 at 4 43 22 PM

@chadwhitacre
Copy link
Member Author

I've created @getsentry-funding and have an IT ticket in to provision an email account so I can SAML with this account. Needed to join the org.

There was an issue joining the organization: Your GitHub user account @getsentry-funding is currently unlinked. However, you are attempting to authenticate with your Identity Provider using the 'bot@sentry.io' SAML identity which is already linked to a different GitHub user account in the organization. Please reach out to one of your GitHub organization owners for assistance.

@chadwhitacre
Copy link
Member Author

I don't actually understand the relationship between the app install on the org and the app connection to my personal account. I suppose the latter is used to login on https://www.stackaid.us/. But if I revoke that, what happens to the org install?

When authorized, the GitHub App will be able to programmatically read the private GitHub resources that you can access (such as private GitHub repositories) where an installation of the GitHub App is also present.

https://docs.github.com/en/authentication/keeping-your-account-and-data-secure/authorizing-github-apps

@chadwhitacre
Copy link
Member Author

Act on your behalf
The application may need to perform tasks on GitHub, as you. This might include creating an issue, or commenting on a pull request. This ability to act on your behalf is limited to the GitHub resources where both you and the GitHub App have access. In some cases, however, the application may never make any changes on your behalf.

@chadwhitacre
Copy link
Member Author

I've revoked access to my personal account for both apps. Both are still installed on the getsentry org. Once SAML is provisioned for @getsentry-funding I'll auth with both apps and have them manually relink our subscriptions with the new account.

@chadwhitacre
Copy link
Member Author

chadwhitacre commented Nov 10, 2022

Currently blocking on IT provisioning an email address for @getsentry-funding.

@chadwhitacre chadwhitacre self-assigned this Nov 15, 2022
@chadwhitacre
Copy link
Member Author

Account provisioned, I've gained access to Gmail and GitHub. Now waiting to be provisioned in GitHub via Okta.

@chadwhitacre
Copy link
Member Author

Provisioned in GitHub. Ready to finalize.

@chadwhitacre
Copy link
Member Author

Need to recover access to bots, lost in the move to Okta for GH.

@chadwhitacre
Copy link
Member Author

Recovered bot access, reached out to SA and TD to switch our account with them over to @getsentry-funding.

@chadwhitacre
Copy link
Member Author

TD done. 💃

@chadwhitacre
Copy link
Member Author

SA done! 💃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant