Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why doesn't sentry support OIDC or OAuth 2.0? #17778

Open
jiankunking opened this issue Mar 19, 2020 · 14 comments
Open

Why doesn't sentry support OIDC or OAuth 2.0? #17778

jiankunking opened this issue Mar 19, 2020 · 14 comments

Comments

@jiankunking
Copy link

Summary

Why doesn't sentry support OIDC or OAuth 2.0?

Motivation

We have deployed sentry ourselves and currently want to do single sign-on with sentry, but found that sentry does not support standard OAuth2.0 and OIDC. I am not sure why sentry does not support it?

Most system single sign-on requirements are for single sign-on with internal accounts, not single sign-on with github or Google accounts.

@mekza
Copy link

mekza commented Apr 2, 2020

It does support OIDC using a 3rd party plugin: https://github.com/siemens/sentry-auth-oidc

@jiankunking
Copy link
Author

It does support OIDC using a 3rd party plugin: https://github.com/siemens/sentry-auth-oidc

We would rather have the official support so that the page can be configured

@max-wittig
Copy link

We discussed this a bit here: #5650 (comment). I still think that it's a mistake to not offically support this, that's why we created the plugin.

@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2021

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Accepted, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@jiankunking
Copy link
Author

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you label it Status: Accepted, I will leave it alone ... forever!

"A weed is but an unloved flower." ― Ella Wheeler Wilcox

i love this words "A weed is but an unloved flower."

@reuwi
Copy link

reuwi commented Apr 11, 2022

I have same confusion about this, there is no reason why it is still not supported offically yet

@Bessonov
Copy link

Just in case someone is interested, sentry supports azure active directory. Works even with self-hosting instances.

@getsantry
Copy link
Contributor

getsantry bot commented Sep 8, 2023

Routing to @getsentry/product-owners-sign-in for triage ⏲️

@chadwhitacre
Copy link
Member

chadwhitacre commented Sep 8, 2023

Seeing an oauth2.py file, which makes me think maybe we support it, but it dates from 2016, which makes me think I don't understand what it does.

class OAuth2Provider(Provider):
"""
The OAuth2Provider is a generic way to implement an identity provider that
uses the OAuth 2.0 protocol as a means for authenticating a user.
OAuth scopes are configured through the oauth_scopes class property,
however may be overridden using the ``config['oauth_scopes']`` object.
"""

@getsantry getsantry bot moved this to Waiting for: Product Owner in GitHub Issues with 👀 Sep 8, 2023
@chadwhitacre
Copy link
Member

Do we support OAuth 2.0 (or OIDC for that matter)?

@Dhrumil-Sentry
Copy link

@nhsiehgit @leedongwei can you please chime in

@bufferoverflow
Copy link

We would love to get rid of our fork https://github.com/siemens/sentry-auth-oidc#why-fork-instead-of-adapting-sentry-auth-google-to-work-with-every-openid-connect-provider and contribute back as we tried here getsentry/sentry-auth-google#29

@getsantry getsantry bot removed the status in GitHub Issues with 👀 Sep 13, 2023
@nhsiehgit
Copy link
Contributor

Hey @chadwhitacre @Dhrumil-Sentry all

We definitely already support OAuth2 and i'm fairly certain we utilize oidc as a client 🤔
It looks like currently we're only connected with 2 oauth providers for SSO though (3 now with Fly)... and the whole sso pipeline is a complete mess to parse through.

Can i ask for more clarification on what we're asking for in this issue?

@Daniel15
Copy link

Daniel15 commented Jan 13, 2024

Can i ask for more clarification on what we're asking for in this issue?

@nhsiehgit - The ability to use any OIDC provider, not just the hard-coded providers. For example, I'd like to use my self-hosted Authentik server. This is available via https://github.com/siemens/sentry-auth-oidc, but given the growing popularity of OIDC (and SSO in general), it should really be a core feature.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Status: No status
Development

No branches or pull requests