Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix samples not building/ bump sentry beta 4 #145

Merged
merged 14 commits into from
Dec 18, 2023
Merged

fix samples not building/ bump sentry beta 4 #145

merged 14 commits into from
Dec 18, 2023

Conversation

lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Dec 11, 2023 •
edited
Loading

This PR Bumps the Beta Sentry 4 and also fixes the following issues:

  • Fix Native crashes line address incorrectly parsed from long string instead of HEX String
  • Removed PublicAPI Check since it was never used and was causing errors locally.
  • Bump internal packages that weren't compatible with the latest Visual Studio for Mac
  • Fixed warnings when using Directory.Build.props
  • Fix MacOS Sample build.

@lucas-zimerman lucas-zimerman marked this pull request as ready for review December 12, 2023 14:34
bitsandfoxes
bitsandfoxes reviewed Dec 13, 2023
View reviewed changes
Directory.Build.props Outdated Show resolved Hide resolved
Samples/Sample.Xamarin.Core/Sample.Xamarin.Core.csproj Outdated Show resolved Hide resolved
Samples/Sample.Xamarin.Droid/Sample.Xamarin.Droid.csproj Outdated Show resolved Hide resolved
Samples/Sample.Xamarin.Mac/Directory.Build.props Show resolved Hide resolved
Samples/Sample.Xamarin.iOS/Sample.Xamarin.iOS.csproj Outdated Show resolved Hide resolved
Src/Sentry.Xamarin/Sentry.Xamarin.csproj Outdated Show resolved Hide resolved
Src/Sentry.Xamarin/Sentry.Xamarin.csproj Outdated Show resolved Hide resolved
@bitsandfoxes
Copy link
Contributor

Thanks for the bump!

bitsandfoxes
bitsandfoxes approved these changes Dec 18, 2023
View reviewed changes
Src/Directory.Build.props Outdated Show resolved Hide resolved
@lucas-zimerman @bitsandfoxes
Update Src/Directory.Build.props
dd08ffb 
Co-authored-by: Stefan Jandl <reg@bitfox.at>
@lucas-zimerman lucas-zimerman changed the base branch from main-beta to main December 18, 2023 19:06
@lucas-zimerman lucas-zimerman merged commit 6463a15 into main Dec 18, 2023
5 checks passed
@lucas-zimerman lucas-zimerman deleted the feat/sentry-4 branch December 18, 2023 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bruno-garcia bruno-garcia bruno-garcia approved these changes

@bitsandfoxes bitsandfoxes bitsandfoxes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucas-zimerman @bitsandfoxes @bruno-garcia