adjust DSN for Android. #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-garcia
reviewed
May 4, 2022
| // Instead of users altering their DSN on their code to use an alternative DSN | ||
| // We'll alter their DSN to the alternative one that works with Xamarin Android. | ||
| // More information: https://github.com/xamarin/xamarin-android/issues/6351 | ||
| => options.Dsn = options.Dsn is not null ? Regex.Replace(options.Dsn, "@.*.ingest.sentry", "@sentry") : null; |
There was a problem hiding this comment.
did you mean:
Suggested change
| => options.Dsn = options.Dsn is not null ? Regex.Replace(options.Dsn, "@.*.ingest.sentry", "@sentry") : null; | |
| => options.Dsn = options.Dsn is not null ? Regex.Replace(options.Dsn, "@o\d+\.ingest\.sentry", "@sentry") : null; |
There was a problem hiding this comment.
We could use this option but I slightly changed it to "@o\\d+\\.ingest\\.sentry" otherwise it wouldn't recognize the slash as a character.
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This additional step alters the current DSN on Android if ran on Saas to use the alternative URL in order to communicate with the server to avoid mono/mono#21233
Fixes #107