Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 0 byte screenshot being sent to Sentry #111

Merged
merged 2 commits into from
Apr 11, 2022
Merged

Conversation

lucas-zimerman
Copy link
Collaborator

@lucas-zimerman lucas-zimerman commented Apr 11, 2022

  • The new behavior will drop the screenshot in case of a failure instead of creating an empty screenshot.

Fixes #86

@lucas-zimerman lucas-zimerman added the bug Something isn't working label Apr 11, 2022
@lucas-zimerman lucas-zimerman marked this pull request as ready for review April 11, 2022 19:00
@lucas-zimerman lucas-zimerman merged commit b7debbf into main Apr 11, 2022
@lucas-zimerman lucas-zimerman deleted the fix/screenshot-null branch April 11, 2022 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Screenshot with 0 bytes breaks preview
1 participant