Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Breadcrumbs on button clicks #864

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

bitsandfoxes
Copy link
Contributor

The idea is to auto-instrument all buttons present in scenes during build time (the OnProcessScene also gets called within the Editor).

@github-actions
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.
Messages
📖 Do not forget to update Sentry-docs with your feature once the pull request gets approved.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Breadcrumbs on button clicks ([#864](https://github.com/getsentry/sentry-unity/pull/864))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 5cb679d

@@ -43,10 +43,63 @@
<Error Condition="'$(UnityManagedPath)' == ''" Text="'UnityManagedPath' not defined. Can't find UnityEngine.dll."></Error>
<Error Condition="!Exists('$(UnityManagedPath)/UnityEngine.dll')" Text="Couldn't find UnityEngine at $(UnityManagedPath)/UnityEngine.dll."></Error>
<ItemGroup>
<!-- <Reference Include="UnityEngine">-->
<!-- <HintPath>$(UnityManagedPath)/UnityEngine.dll</HintPath>-->
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That here needs some cleaning up but the gist of it is: ManagedPath/UnityEngine.dll on the managed root contains all the type forwarders to the modules inside of ManagedPath/UnityEngine/. This does not seem to work 100% of the time like with LogAssert in the test projs. Instead, we could just reference the individual modules.


namespace Sentry.Unity
{
public class SentryScene : MonoBehaviour
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a callback to a button relies on a MonoBehaviour being a permanent part of the scene. SentryMonoBehaviour get created during runtime and the callback would fail.

@getsantry getsantry bot added the Stale label Oct 18, 2023
@getsantry
Copy link

getsantry bot commented Oct 18, 2023

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant