Change access modifier to private for stack trace mode option setter
#1806
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tustanivsky
changed the title
private for stack trace mode option setter
bruno-garcia
requested changes
Sep 27, 2024
| @@ -7,6 +7,10 @@ | |||
| - Contexts, such as `device` and `gpu` that the SDK retrieves during the game's startup is now available even earlier and irrespective whether an error was captured on the main or on a background thread ([#1802](https://github.com/getsentry/sentry-unity/pull/1802)) | |||
| - Added an `ApplicationNotRespondingException` type that allows filtering of ANR events ([#1800](https://github.com/getsentry/sentry-unity/pull/1800)) | |||
|
|
|||
| ### Fixes | |||
|
|
|||
| - Change access modifier to `private` for stack trace mode option setter ([#1806](https://github.com/getsentry/sentry-unity/pull/1806)) | |||
There was a problem hiding this comment.
Suggested change
| - Change access modifier to `private` for stack trace mode option setter ([#1806](https://github.com/getsentry/sentry-unity/pull/1806)) | |
| - Change access modifier of `StackTraceMode` to `private` to avoid pitfall ([#1806](https://github.com/getsentry/sentry-unity/pull/1806)) |
|
What we wanted to achieve was take away the footgun for users to switch mode and break their game by hiding the property. But it's still accessible via the base class. With this we're giving the "no-footgun!" attempt a second chance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR should prevent users from accidentally enabling
Enhancedstack trace mode via theSentryUnityOptionsparent class property. Enhanced mode is not supported in IL2CPP builds (see #1033 for more details) and thus could cause crashes like in #1783.Closes #1783