Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FPS metrics #142

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from
Draft

FPS metrics #142

wants to merge 1 commit into from

Conversation

bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented May 5, 2021

Test if we can validate fps:

Metric used here:

  • Good frames ( < 20ms )
  • Bad frames ( > 20ms but not yet frozen)
  • Frozen frames

Frozen frame issue: Unity has a limit on how big delta time can get to preserve continuity for the player experience. We could work around that by calculating the delta time ourselves -> MeasureDeltaTime()
Things to consider for the metrics:

  • How often did the game get frozen
  • How long was is frozen for

Screenshot 2021-05-05 at 10 37 48
#skip-changelog

}
else
{
goodFrames++;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some thoughts:
Should we use long here? And if so, do we need Interlocked.Increment? And if we do :) does that work everywhere on Unity, like WebGL?

@bitsandfoxes bitsandfoxes self-assigned this Jun 4, 2021
@bitsandfoxes bitsandfoxes changed the title POC: FPS metric FPS metrics Jun 14, 2021
@bruno-garcia
Copy link
Member

Once we have some transactions being generated (see: #235) we can get back to this PR and add some measurements

@getsantry
Copy link

getsantry bot commented Oct 18, 2023

This issue has gone three weeks without activity. In another week, I will close it.

But! If you comment or otherwise update it, I will reset the clock, and if you remove the label Waiting for: Community, I will leave it alone ... forever!


"A weed is but an unloved flower." ― Ella Wheeler Wilcox 🥀

@getsantry getsantry bot added the Stale label Oct 18, 2023
@bruno-garcia
Copy link
Member

@bitsandfoxes this one soon will make sense? with the new metrics stuff

@bruno-garcia
Copy link
Member

@bitsandfoxes with 4.0.0 you could use this now

@bitsandfoxes
Copy link
Contributor Author

@bitsandfoxes with 4.0.0 you could use this now

I think the name is misleading. Initially, we wanted to have those as mobile vitals.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants