fix: hide StackTraceMode from options to avoid accidental errors when used with IL2CPP
#1033
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… used with IL2CPP
vaind
changed the title
StackTraceMode from options to avoid accidental errors when used with IL2CPP
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- hide `StackTraceMode` from options to avoid accidental errors when used with IL2CPP ([#1033](https://github.com/getsentry/sentry-unity/pull/1033))If none of the above apply, you can opt out of this check by adding |
bitsandfoxes
approved these changes
Oct 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #879
closes #46
I've implemented the solution suggested here: #879 (comment) - not sure it's the best thing to do since we're completely forbidding anyone to use the
Enhancedmode, even with Mono.I was also thinking about using a custom setter that would throw in case you tried to set
Enhancedwith IL2CPP but we need to haveISentryUnityinfo provided and it doesn't seem like we must have it at all times (not a mandatory argument to Options at the moment).