Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra options in ALLOWED_LIST of ActiveSupportLogger #2135

Closed
igordepolli opened this issue Oct 10, 2023 · 2 comments
Closed

Extra options in ALLOWED_LIST of ActiveSupportLogger #2135

igordepolli opened this issue Oct 10, 2023 · 2 comments

Comments

@igordepolli
Copy link
Contributor

Hi,

The pull request #2048 add a constant called ALLOWED_LIST to filter ActiveSupport breadcrumbs data. I would like to know if it is possible to make the addition/removal of allowed attributes dynamic.

The reason? Well, in our company, we used to use a lot for the type_casted_binds attribute that the subscription in sql.active_record gives us. This attribute provides us with all the where clauses for the queries that were made up to the time of the raise, which helped a lot with debugging for our cases.

I understand that it may not be a universal need, so my idea to implement this would be to make this addition of extra attributes optional on initialize, like excluded exceptions, for example.

@sl0thentr0py
Copy link
Member

yea we can make this configurable, feel free to PR if you want it quicker :)

@igordepolli
Copy link
Contributor Author

yea we can make this configurable, feel free to PR if you want it quicker :)

@sl0thentr0py PR opened :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

No branches or pull requests

2 participants