Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Horizon Support #90

Closed
dcramer opened this issue Jul 26, 2017 · 3 comments
Closed

Horizon Support #90

dcramer opened this issue Jul 26, 2017 · 3 comments

Comments

@dcramer
Copy link
Member

dcramer commented Jul 26, 2017

@taylorotwell suggested we could do this via simple handlers:

https://twitter.com/taylorotwell/status/890209354934341638

This lines up to how we attach in other systems (e.g. Python) so should be straight forward. We'd want to grab tags and alike by default.

@stayallive
Copy link
Collaborator

stayallive commented Jul 26, 2017

We could actually do this without Horizon too.

Illuminate\Queue\Events\JobFailed

@dcramer
Copy link
Member Author

dcramer commented Jul 26, 2017

so it sounds like the Horizon event is based on the illuminate JobFailed, but it extends it with additional metadata (e.g. queue name)

https://github.com/laravel/horizon/blob/master/src/Listeners/MarkJobAsFailed.php

@stayallive
Copy link
Collaborator

I believe this has been tackled by #153.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants