Error-based replays do not continue to buffer after an initial replay is captured

[billyvg]

For "error-based" sampling, we buffer the replay events until an error occurs. After an error occurs, we upload the replay and continue to record the replay and treat the rest of the replay as a "session-based" replay. After this session expires, we stop replay completely. In order to capture replays again on that browser tab, two things must occur: 1) session in session storage has to be expired and 2) user has to reload the tab.

Session-based replays will get resampled after they expire, so I think it makes sense to restart buffering mode after an error-based replay is completed.

[mydea]

Yes, I think I agree - expected behavior would be to start a regular session, when it's over switch back to buffering.

Thinking about this, does this also make sense for regular sessions? 🤔 so whenever a session is over (no matter why) we switch to buffering mode (unless on error sample rate is 0)? Would probably simplify this a bit.

[egissan]

@mydea @billyvg Any updates on this issue? Basically it's blocking us to ditch old rrweb approach and integrate new Sentry Replays feature.

[mydea]

Hi @egissan. We have an open PR hopefully fixing this issue. However, as this touches a lot of code and behavior, we are giving it some extra care & review time to make sure it works as expected. We'll hopefully be able to really land it in a release soon! We'll keep this issue updated.

[egissan]

Thank you for the update! 🙏
Looking forward to the release

[mydea]

We changed the behavior around this, I think we handle this better now!