-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Koa scopes are not isolated between requests #13992
Comments
Full log
|
Hi @TheHolyWaffle thanks for writing in. Do you have a reproduction repo for this? I've tried it out locally using tsx and the code snippets you provided but I'm getting
I'm also not getting
If you create a github repo or a stackblitz we can take a better look. |
Aha, it was related due to multiple versions
Re-generating But I'm not sure how to prevent this in the future as we use Also, the only way to visualize this error is by turning on |
@TheHolyWaffle great, glad it's been resolved. I agree it's hard to spot these. We'll discuss possibly failing differently here. Thanks again for filing! |
Is there an existing issue for this?
How do you use Sentry?
Sentry Saas (sentry.io)
Which SDK are you using?
@sentry/node
SDK Version
8.34.0
Framework Version
koa 2.15.3, @koa/router 13.1.0
Link to Sentry event
No response
Reproduction Example/SDK Setup
instrument.ts
server.ts
Steps to Reproduce
npx tsx server.ts
/
endpoint with a GET request and a URL query parametertest
set tofoo
/
endpoint again, but change query parameter value tofoo2
Expected Result
The expected result is that the Sentry tag
query
is not persisted across consecutive incoming HTTP requests. Wrapping the/
handler withSentry.withScope
does not fix thisIn practice this means the second trigger should output:
Actual Result
The second trigger outputs:
The text was updated successfully, but these errors were encountered: