New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Renable http instrumentation test for node-express-esm-preload #12590

Open

AbhiPrasad opened this issue Jun 20, 2024 · 0 comments

Labels

Package: node Type: Tests

Member

AbhiPrasad commented Jun 20, 2024 •

edited

Loading

sentry-javascript/dev-packages/e2e-tests/test-applications/node-express-esm-preload/tests/server.test.ts

Lines 125 to 127 in 00ee962

    
           // This fails https://github.com/getsentry/sentry-javascript/pull/12587#issuecomment-2181019422 
        
           // Skipping this for now so we don't block releases 
        
           test.skip('Should record spans from http instrumentation', async ({ request }) => {

#12587 (comment)

This was disabled to unblock a release, make this work now!

The text was updated successfully, but these errors were encountered:

AbhiPrasad added Package: node Type: Tests labels

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment