Skip to content

Commit d269f1c

Browse files
authored
ci: Ensure we fail on cancelled jobs (#17506)
See https://github.com/getsentry/sentry-javascript/actions/runs/17398257702/job/49385642947, this seems to not trigger the failure, I guess this is `cancelled` not `failure` I could not really find good documentation on this but I suppose this should work!
1 parent 1df660b commit d269f1c

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/build.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1137,6 +1137,6 @@ jobs:
11371137
runs-on: ubuntu-24.04
11381138
steps:
11391139
- name: Check for failures
1140-
if: contains(needs.*.result, 'failure')
1140+
if: cancelled() || contains(needs.*.result, 'failure') || contains(needs.*.result, 'cancelled')
11411141
run: |
11421142
echo "One of the dependent jobs have failed. You may need to re-run it." && exit 1

0 commit comments

Comments
 (0)