Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate withScope #2083

Closed
adinauer opened this issue Jun 7, 2022 · 2 comments
Closed

Deprecate withScope #2083

adinauer opened this issue Jun 7, 2022 · 2 comments
Assignees
@markushi
Labels
Platform: Java

Comments

@adinauer
Copy link
Member

adinauer commented Jun 7, 2022

Problem Statement

Overloads for capture are added via #1829, let's deprecate withScope as it has some cases where other calls to capture also have the scope from withScope.

Solution Brainstorm

Deprecate in v6, then remove in v7.
@adinauer adinauer moved this to Needs Discussion in Mobile & Cross Platform SDK Jun 7, 2022
This was referenced Jun 7, 2022
Closed
Merged
@adinauer adinauer moved this from Needs Discussion to Backlog in Mobile & Cross Platform SDK Jun 8, 2022
@adinauer adinauer added this to the 7.0.0 milestone Dec 1, 2022
@marandaneto
Copy link
Contributor

Unified API didn't deprecate this https://develop.sentry.dev/sdk/unified-api/
Confirm during TSC and update Unified spec?

@markushi markushi removed this from the 7.0.0 milestone Aug 8, 2023
@markushi markushi self-assigned this Aug 8, 2023
@markushi
Copy link
Member

markushi commented Aug 8, 2023

As this came up recently, there are certain use cases for web/backend where withScope() makes actually sense. Thus there's no need to deprecate it. Some more javadoc was added here, as withScope() in combination with globalHubMode doesn't play well together.

@markushi markushi closed this as not planned Won't fix, can't repro, duplicate, stale Aug 8, 2023
@github-project-automation github-project-automation bot moved this from Backlog to Done in Mobile & Cross Platform SDK Aug 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@markushi markushi

Labels
Platform: Java
Projects
Mobile & Cross Platform SDK
Archived in project
Milestone
No milestone
Development

No branches or pull requests
4 participants
@markushi @kahest @adinauer @marandaneto