span.Finish()
should be a noop when span is already finished
#587
Labels
span.Finish()
should be a noop when span is already finished
#587
At the moment we allow to call
Finish()
on spans (and, specifically, transactions) multiple times, and run the fullFinish()
logic every time.It's not optimal, because finalizing the same span/transaction is not something that we officially support or recommend, and it also might cause a data race, as in the following example:
Data race log
The proposal is to make
Span.Finish()
a no-op afterFinish()
has already been called once.Extracted from #570
The text was updated successfully, but these errors were encountered: