-
-
Notifications
You must be signed in to change notification settings - Fork 206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: Bump to net8.0-x
#3613
chore: Bump to net8.0-x
#3613
Conversation
Instructions and example for changelogPlease add an entry to Example: ## Unreleased
- Bump to `net8.0-x` ([#3613](https://github.com/getsentry/sentry-dotnet/pull/3613)) If none of the above apply, you can opt out of this check by adding |
@bitsandfoxes this is what I've been spinning my wheels on for over a week now in the feat/net9 PR. There are now 4 issues/PRs realted to this ;-)
As it involves dropping support for net7.0, I don't think we want to do this in the main branch. |
I'm still on 15.4 btw. What was the motivation for upgrading to 16? |
True. But if just bumping to the newest .NET 8 we're in a bit of a pickle here. And I can't restore my local dev environment to build the SDK anymore without those changes. Spend quite a bit of time trying tho.
Just got prompted for its availability and someone is going to run into it sooner than later. |
Agree, it's not ideal. The original device runners were vendored in from here: I spent all day today trying to update the code we have in Sentry from the latest in that main branch and I have it building... but when I try to run the device tests nothing happens 😢
[Edit:] Actually I got the tests running when using this NuGet package... which is probably a good thing (means we can delete all that code we copied into the repo)... however the same tests still fail with the CastleProxy error. And I spent a couple of days before that building a minimal repro for what I thought was a problem referencing internal members of strongly named assemblies. Frustratingly, the tests in that one pass 🤕 I feel like I'm spinning on a mouse wheel here a bit... I've got one more thing I can try, that Bruno suggested. After that, the only thing I can think to do is to open an issue on the CastleProxy repo with a variant of that minimal repro (referencing the Sentry.Tests.dll). |
Prolly not the best of ideas right now |
Issue
Having updated to
Xcode 16.0
I was no longer able to build the SDK. The errorcontained some references regarding the iOS simulator tools not being found at a specified path. So I opted to update the rest of the tooling as well to
.NET 8.0.401
.This lead to the following error
Local environment
My local dev environment has
And the following workloads
Solution
Drop
.net7.0-x
support?