fix: FormatException when reading ProcessorFrequency
#3541
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
6 tasks
bitsandfoxes
changed the title
ProcessorFrequencyFormatException when reading ProcessorFrequency
jamescrosswell
requested changes
Aug 16, 2024
src/Sentry/Protocol/Device.cs
Outdated
| // The Java SDK reports the processorFrequency as `double` | ||
| // Java https://github.com/getsentry/sentry-java/blob/9762f09afa51944b40a9b77e116a55e54636e6c5/sentry/src/main/java/io/sentry/protocol/Device.java#L130 | ||
| int? processorFrequency = null; | ||
| var processorFrequencyProperty = json.GetPropertyOrNull("processor_frequency"); |
There was a problem hiding this comment.
Should we change one of our tests as well (to make sure it works when deserialising a double)?
There was a problem hiding this comment.
AFAIK, we don't have any tests for Device as it's not doing anything. But the type-mismatch is obvious from looking at the Java code.
There was a problem hiding this comment.
I don't want to argue against writing tests. I've added it to #3542
bruno-garcia
approved these changes
Aug 20, 2024
jamescrosswell
approved these changes
Aug 24, 2024
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3540