Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Read and send unfinished spans #3533

Merged
merged 4 commits into from
Aug 14, 2024
Merged

Conversation

bitsandfoxes
Copy link
Contributor

@bitsandfoxes bitsandfoxes commented Aug 14, 2024

Fixes getsentry/sentry-unity#1759

With getsentry/relay#1244 spans no longer need to be finished before sent. Without making reading the endTimestamp optional we end up with an error

System.Collections.Generic.KeyNotFoundException: The given key was not present in the dictionary.

Copy link
Collaborator

@jamescrosswell jamescrosswell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

CHANGELOG.md Outdated Show resolved Hide resolved
@jamescrosswell jamescrosswell merged commit b0fc43e into main Aug 14, 2024
10 of 11 checks passed
@jamescrosswell jamescrosswell deleted the fix/unfinished-span branch August 14, 2024 21:54
Copy link
Contributor

Fails
🚫 Please consider adding a changelog entry for the next release.

Instructions and example for changelog

Please add an entry to CHANGELOG.md to the "Unreleased" section. Make sure the entry includes this PR's number.

Example:

## Unreleased

- Read and send unfinished spans ([#3533](https://github.com/getsentry/sentry-dotnet/pull/3533))

If none of the above apply, you can opt out of this check by adding #skip-changelog to the PR description.

Generated by 🚫 dangerJS against 3d82dfb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants