Fixed Trim warnings in DiagnosticSource and WinUIUnhandledException integrations #3410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamescrosswell
changed the title
bitsandfoxes
reviewed
Jun 6, 2024
src/Sentry.DiagnosticSource/Internal/DiagnosticSource/ReflectionHelper.cs
Outdated
Show resolved
Hide resolved
| /// </remarks> | ||
| internal static class ReflectionHelper | ||
| { | ||
| [UnconditionalSuppressMessage("TrimAnalyzer", "IL2075", Justification = AotHelper.SuppressionJustification)] |
There was a problem hiding this comment.
Curious: Could we have added the attribute where this was moved from, instead of having that in a new ReflectionHelper?
There was a problem hiding this comment.
We could have yes. The main reason I moved it was to put it in the DiagnosticSource namespace (to make it clear that it wasn't intended to be used beyond that scope - it's a bit of a retro way of instrumenting things and I don't think we want to replicate this anywhere else).
It was in a MiscExtensions class so it it wasn't closely related to any of the other functionality that we pulled this away from.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #3304
TODO: Testing
Sentry.Samples.Console.Basicproject with trimming enabledAotHelper.IsTrimmedso that we could "mock" this during testing.