Fixed envelopes with large attachments persist on disk

CHANGELOG.md

@@ -10,6 +10,7 @@
 
 - `HttpResponse.Content` is no longer disposed by when using `SentryHttpFailedRequestHandler` on .NET Framework, which was causing an ObjectDisposedException when using Sentry with NSwag ([#3306](https://github.com/getsentry/sentry-dotnet/pull/3306))
 - Fix BackgroundWorker exiting when OperationCanceledException is not from shutdown request ([3284](https://github.com/getsentry/sentry-dotnet/pull/3284))
+- Envelopes with large attachments no longer get stuck in the queue when using `CacheDirectoryPath` ([#3328](https://github.com/getsentry/sentry-dotnet/pull/3328))
 
 ## 4.4.0
 

src/Sentry/Http/HttpTransportBase.cs

@@ -127,7 +127,7 @@ private void ProcessEnvelopeItem(DateTimeOffset now, EnvelopeItem item, List<Env
 
         // If attachment, needs to respect attachment size limit
         if (string.Equals(item.TryGetType(), "attachment", StringComparison.OrdinalIgnoreCase) &&
-            item.TryGetLength() > _options.MaxAttachmentSize)
+            item.TryGetOrRecalculateLength() > _options.MaxAttachmentSize)
         {
             // note: attachment drops are not currently counted in discarded events
 

src/Sentry/Protocol/Envelopes/EnvelopeItem.cs

@@ -76,6 +76,21 @@ public EnvelopeItem(IReadOnlyDictionary<string, object?> header, ISerializable p
             var value => Convert.ToInt64(value) // can be int, long, or another numeric type
         };
 
+    internal long? TryGetOrRecalculateLength()
+    {
+        if (TryGetLength() is { } headerLength)
+        {
+            return headerLength;
+        }
+
+        if (Payload is StreamSerializable streamSerializable)
+        {
+            return streamSerializable.Source.TryGetLength();
+        }
+
+        return null;
+    }
+
     /// <summary>
     /// Returns the file name or null if no name exists.
     /// </summary>

test/Sentry.Tests/Protocol/Envelopes/EnvelopeTests.cs

@@ -749,6 +749,8 @@ public async Task Roundtrip_WithEvent_WithAttachment_Success()
             .Which.Source.Should().BeEquivalentTo(@event);
 
         envelopeRoundtrip.Items[1].Payload.Should().BeOfType<StreamSerializable>();
+        envelopeRoundtrip.Items[1].TryGetLength().Should().BeNull();
+        envelopeRoundtrip.Items[1].TryGetOrRecalculateLength().Should().Be(attachment.Content.GetStream().Length);
     }
 
     [Fact]