Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: MAUI eventbinding moved to FinishedLaunching #3057

Merged
merged 4 commits into from
Jan 18, 2024
Merged

Conversation

bitsandfoxes
Copy link
Contributor

Fixes #2898

So there is nothing really "fixed" here. Putting it in bitwarden just highlighted a potential issue with the SDK.
There the app relies on the FinishedLaunching callback to setup their own service container before instantiating the app. The SDK's call into services causes the app to be instantiated first.
Considering that other applications might be doing the same I think it's fair to move the binding to the FinishedLaunching as well.

Copy link

codecov bot commented Jan 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (2378822) 75.26% compared to head (0aba6e6) 76.43%.
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3057      +/-   ##
==========================================
+ Coverage   75.26%   76.43%   +1.17%     
==========================================
  Files         351      351              
  Lines       13257    13262       +5     
  Branches     2645     2646       +1     
==========================================
+ Hits         9978    10137     +159     
+ Misses       2603     2447     -156     
- Partials      676      678       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bitsandfoxes bitsandfoxes merged commit feabf09 into main Jan 18, 2024
21 checks passed
@bitsandfoxes bitsandfoxes deleted the fix/maui-binding branch January 18, 2024 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4.0 Beta 1: MAUI app crashes on Init on iPad Simular
3 participants