fix: OTel spans for Sentry requests #3001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruno-garcia
approved these changes
Jan 3, 2024
| @@ -113,7 +113,7 @@ public override void OnEnd(Activity data) | |||
| // Make a dictionary of the attributes (aka "tags") for faster lookup when used throughout the processor. | |||
| var attributes = data.TagObjects.ToDict(); | |||
|
|
|||
| if (attributes.TryGetTypedValue("http.url", out string? url) && (_options?.IsSentryRequest(url) ?? false)) | |||
| if (attributes.TryGetTypedValue("url.full", out string? url) && (_options?.IsSentryRequest(url) ?? false)) | |||
There was a problem hiding this comment.
this approach to detect if it's a Sentry request seems rather fragile
jamescrosswell
requested changes
Jan 4, 2024
jamescrosswell
requested changes
Jan 4, 2024
There was a problem hiding this comment.
Sorry, should have put this in the original review... might be good to change this test from a Fact to a Theory and test it with both the old and the new:
sentry-dotnet/test/Sentry.OpenTelemetry.Tests/SentrySpanProcessorTests.cs
Lines 381 to 382 in 41714ae
At the moment, it only tests the old attributes.
jamescrosswell
approved these changes
Jan 5, 2024
This was referenced Jan 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2998
Looks like the key changed.