Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Android binding warnings #2950

Merged
merged 3 commits into from
Dec 6, 2023
Merged

fix: Android binding warnings #2950

merged 3 commits into from
Dec 6, 2023

Conversation

bitsandfoxes
Copy link
Contributor

Fixes:

Unknown parameter type 'io.sentry.android.core.internal.util.SentryFrameMetricsCollector' for member 'Sentry.JavaSdk.Android.Core.AndroidProfiler.AndroidProfiler (string, int, io.sentry.android.core.internal.util.SentryFrameMetricsCollector, io.sentry.ISentryExecutorService, io.sentry.ILogger, io.sentry.android.core.BuildInfoProvider)'.

Java SDK 7.0.0 made the AndroidProfiler dependant on SentryFrameMetricsCollector is it gets yeeted too. (together with its nested types)

Metadata.xml element '<remove-node path="/api/package[@name='io.sentry']/interface[@name='IntegrationName']/method[@name='addIntegrationToSdkVersion']" />' matched no nodes.

IntegrationUtils.addIntegrationToSdkVersion changed in 7.0.0 as well and no longer needs this workaround.

#skip-changelog

Copy link
Collaborator

@vaind vaind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

the integration test failure looks like the issue with the proguard mapping PR which has bee reverted in the meantime, so merging.

@vaind vaind merged commit 2c55bf3 into main Dec 6, 2023
16 of 19 checks passed
@vaind vaind deleted the fix/android-bindings branch December 6, 2023 19:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants