Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

IsAotCompatible for uncomplicated projects #2793

Merged
merged 7 commits into from
Nov 8, 2023
Merged

IsAotCompatible for uncomplicated projects #2793

merged 7 commits into from
Nov 8, 2023

Conversation

jamescrosswell
Copy link
Collaborator

@jamescrosswell jamescrosswell commented Nov 6, 2023 •
edited
Loading

Added IsAotCompatible to all the integrations where this is very straight forward (low hanging fruit described in #2780).

@jamescrosswell jamescrosswell marked this pull request as ready for review November 6, 2023 01:40
@jamescrosswell jamescrosswell mentioned this pull request Nov 7, 2023
Closed
bruno-garcia
bruno-garcia approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than changing EF6, I'm good with this.
AspNetCore is the largest opportunity for us with AOT. And I imagine it'll be the hardest thing?

@jamescrosswell
Copy link
Collaborator Author

Other than changing EF6, I'm good with this. AspNetCore is the largest opportunity for us with AOT. And I imagine it'll be the hardest thing?

I've reverted Sentry.EntityFramework to match how it is in the feat/4.0.0 branch.

wrt AspNetCore, the only issue I know of yet is that is uses ConfigureFromConfigurationOptions<TOptions>. Beyond that, I'm not sure. We'll need some integration tests at the very least. Maybe we should try to dogfood it though... rather than wait for the community to spot really basic stuff.

@jamescrosswell jamescrosswell merged commit 8b89fcd into feat/4.0.0 Nov 8, 2023
10 checks passed
@jamescrosswell jamescrosswell deleted the trimming-all-easy branch November 8, 2023 03:41
This was referenced Nov 16, 2023
Merged
Draft
Merged
@jamescrosswell jamescrosswell mentioned this pull request Nov 26, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vaind vaind vaind left review comments

@bruno-garcia bruno-garcia bruno-garcia approved these changes

@bitsandfoxes bitsandfoxes Awaiting requested review from bitsandfoxes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jamescrosswell @bruno-garcia @vaind