Re-enable HubTests.FlushOnDispose_SendsEnvelope #2492
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jamescrosswell
commented
Jul 18, 2023
jamescrosswell
requested review from
bitsandfoxes and
SeanFeldman
as code owners
jamescrosswell
requested review from
bitsandfoxes
and removed request for
bitsandfoxes
jamescrosswell
changed the title
jamescrosswell
changed the title
SeanFeldman
approved these changes
Jul 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2156
Summary
Investigation
I created a
RepeatAttribute.csfor XUnit that allows a test to be run an arbitrary number of times.Initially I tried setting the number of repeats on this theory to 100, but the Android CI servers fell over when I did that... which is a pity. Worth noting that the other CI servers didn't have any problem with this, so there's definitely something special about the Android CI servers in this respect.
When I dropped the number of test repeats to 20, the Android CI servers seemed to be able to cope again and all the tests passed. I reran the jobs for Android 4 times. Across 5 x different versions of Android then, including the original run, that's 500 tests and no failures.
Recommendation
I think we can re-enable this test. If we're happy with that, I'll uncomment the InlineData attribute and delete the Repeat attribute that are currently sitting on the test.