Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop embedding PDBs #2166

Merged
merged 4 commits into from
Feb 8, 2023
Merged

Stop embedding PDBs #2166

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
bb3c316
Don't embed PDBs
mattjohnsonpint Feb 8, 2023
41a6f06
Publish symbols to nuget
mattjohnsonpint Feb 8, 2023
118d04b
Update CHANGELOG.md
mattjohnsonpint Feb 8, 2023
b314036
Update CHANGELOG.md
mattjohnsonpint Feb 8, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -72,3 +72,4 @@ jobs:
if-no-files-found: error
path: |
${{ github.workspace }}/src/**/Release/*.nupkg
${{ github.workspace }}/src/**/Release/*.snupkg
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,6 +5,7 @@
### Fixes

- Workaround Visual Studio "Pair to Mac" issue (on Windows), and Update bundled Cocoa SDK to version 7.31.5 ([#2164](https://github.com/getsentry/sentry-dotnet/pull/2164))
- Sentry SDK assemblies no longer have PDBs embedded. Debug symbols are uploaded to `nuget.org` as `snupkg` packages ([#2166](https://github.com/getsentry/sentry-dotnet/pull/2166))

## 3.27.1

Expand Down
13 changes: 7 additions & 6 deletions src/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,17 +23,18 @@
<PackageLicenseExpression>MIT</PackageLicenseExpression>
<PackageReadmeFile>README.md</PackageReadmeFile>

<!-- Prop required by Microsoft.SourceLink.GitHub -->
<!-- Publish the repository URL in the built .nupkg (in the NuSpec <Repository> element) -->
<!--
SourceLink configuration
See https://github.com/dotnet/sourcelink/blob/main/README.md
And https://learn.microsoft.com/dotnet/core/project-sdk/msbuild-props
-->
<PublishRepositoryUrl>true</PublishRepositoryUrl>
<!-- Embed source files that are not tracked by the source control manager in the PDB -->
<IncludeSymbols>true</IncludeSymbols>
<SymbolPackageFormat>snupkg</SymbolPackageFormat>
<EmbedUntrackedSources>true</EmbedUntrackedSources>
<!-- Embed PDB inside the assembly -->
<DebugType>embedded</DebugType>
<IncludeSourceRevisionInInformationalVersion>false</IncludeSourceRevisionInInformationalVersion>

<Nullable>annotations</Nullable>

<CodeAnalysisRuleSet>$(MSBuildThisFileDirectory)CodeAnalysis.ruleset</CodeAnalysisRuleSet>
</PropertyGroup>

Expand Down