Stop embedding PDBs #2166
Merged
Stop embedding PDBs #2166
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks like craft is going to need an update to support the |
bruno-garcia
reviewed
Feb 8, 2023
Co-authored-by: Bruno Garcia <bruno@brunogarcia.com>
bruno-garcia
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now have support for NuGet symbol servers in Sentry, configurable on the
Debug Filestab, from the project settings in the Sentry UI.Thus, there's no longer any need to embed symbols in the PDBs themselves. Instead, we'll publish NuGet Symbols package (
.snupkg) files.Note: For now, we will also still upload them to Sentry directly via Sentry CLI so that we get sources in the Sentry UI. Eventually we'll be able to just rely on SourceLink (see getsentry/symbolic#735).
Fixes #2159.