Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sentry CLI MSBuild for Xamarin and NetFX #2154

Merged
merged 4 commits into from
Feb 3, 2023
Merged

Conversation

mattjohnsonpint
Copy link
Contributor

Some further testing on Xamarin and .NET Framework projects after the 3.27.0 release, found symbol uploads not working as expected.

  • We can't rely on checking for a non-empty TargetFramework property, because that only exists in the newer SDK-style .NET projects. Since the intention here is to run for anything other than the outer build when multi-targeting, we can check for an empty InnerTargets property (which is only set in the case we need to exclude).

  • On Xamarin Android projects, we always will need the obj folder contents rather than bin to get the correct debug files uploaded. Since the obj folder is guaranteed to always have the files we need, we should make it the default and remove the SentryIncludeIntermediateOutputPath option. (We don't need to use the bin folder at all.)

@mattjohnsonpint mattjohnsonpint merged commit 5014553 into main Feb 3, 2023
@mattjohnsonpint mattjohnsonpint deleted the fix-msbuild branch February 3, 2023 19:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants