Fix Android support for Portable PDB format when app uses split APKs #2108
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When an Android app is built in release configuration, it may be configured to be deployed to the device using multiple "split" APKs. For example, building
Sentry.Samples.Androidin release mode, after deploying to a device and browsing the device file system, looks like this:Previously, we were getting the APK at runtime using
Environment.CommandLine- but in the case of multiple APKs, that will resolve to one of the splits, not to the base APK where the assemblies are located. Thus, we weren't getting the debug info sent to Sentry in the stack trace.Resolved by getting the base APK path from the Android application context info.
I don't think assemblies will ever be in one of the splits, but I left a comment about it in the code just in case that comes up in the future.