Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Dynamic Sampling #1953

Merged
merged 30 commits into from
Oct 4, 2022
Merged

Support Dynamic Sampling #1953

merged 30 commits into from
Oct 4, 2022

Conversation

mattjohnsonpint
Copy link
Contributor

@mattjohnsonpint mattjohnsonpint commented Sep 28, 2022 •
edited
Loading

Adding .NET SDK support for dynamic sampling, per #1840

Includes:

  • DynamicSamplingContext
  • BaggageHeader
  • TracePropagationTarget
  • Outbound headers sent with SentryHttpMessageHandler
  • Inbound headers respected in ASP.NET and ASP.NET Core tracing integrations
  • Lots of tests

@mattjohnsonpint mattjohnsonpint changed the title WIP: Dynamic sampling Support Dynamic Sampling Sep 29, 2022
@SimonCropp
Copy link
Contributor

would any of this be useful https://github.com/VerifyTests/Verify.Http ?

@mattjohnsonpint
Copy link
Contributor Author

would any of this be useful https://github.com/VerifyTests/Verify.Http ?

In general, yes. But not at this time. Thanks.

@mattjohnsonpint mattjohnsonpint marked this pull request as ready for review October 4, 2022 01:35
@mattjohnsonpint mattjohnsonpint merged commit 0d85ef6 into main Oct 4, 2022
@mattjohnsonpint mattjohnsonpint deleted the dynamic-sampling branch October 4, 2022 22:16
@mattjohnsonpint mattjohnsonpint mentioned this pull request Oct 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marandaneto marandaneto marandaneto left review comments

@SimonCropp SimonCropp SimonCropp approved these changes

@bruno-garcia bruno-garcia Awaiting requested review from bruno-garcia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mattjohnsonpint @SimonCropp @marandaneto