Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support IntPtr and UIntPtr serialization #1746

Merged
merged 5 commits into from
Jun 28, 2022
Merged

Support IntPtr and UIntPtr serialization #1746

merged 5 commits into from
Jun 28, 2022

Conversation

SimonCropp
Copy link
Contributor

@SimonCropp SimonCropp commented Jun 25, 2022 •
edited
Loading

fixes #1735

bruno-garcia
bruno-garcia approved these changes Jun 25, 2022
View reviewed changes
Copy link
Member

@bruno-garcia bruno-garcia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SimonCropp
Copy link
Contributor Author

@bruno-garcia one thing of concern is nuinit and nint tests passed with no mods. which seems to conflict with the issue #1735

@SimonCropp SimonCropp changed the title IntPtr serialization Support IntPtr and UIntPtr serialization Jun 25, 2022
@getsentry getsentry deleted a comment from github-actions bot Jun 25, 2022
@SimonCropp @mattjohnsonpint
Update test/Sentry.Tests/SerializationTests.cs
5de18a2 
Co-authored-by: Matt Johnson-Pint <matt.johnson-pint@sentry.io>
@SimonCropp
Copy link
Contributor Author

from @mattjohnsonpint

When I was looking before, I think nint and nuint get automagically treated as IntPtr and UIntPtr

and i confirmed

@SimonCropp SimonCropp merged commit b434388 into main Jun 28, 2022
@SimonCropp SimonCropp deleted the IntPtr-serialization branch June 28, 2022 00:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattjohnsonpint mattjohnsonpint mattjohnsonpint approved these changes

@bruno-garcia bruno-garcia bruno-garcia approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Sentry JsonConverter can't handle IntPtr/UIntPtr/nint/nuint types.
3 participants
@SimonCropp @mattjohnsonpint @bruno-garcia