Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add type checking in contexts try get value #1700

Merged
merged 4 commits into from
Jun 7, 2022
Merged

Add type checking in contexts try get value #1700

merged 4 commits into from
Jun 7, 2022

Conversation

SimonCropp
Copy link
Contributor

mitigates #1695

@SimonCropp
Copy link
Contributor Author

SimonCropp commented Jun 7, 2022 •
edited
Loading

@bruno-garcia @mattjohnsonpint a better fix would be for Contexts to not inherit from ConcurrentDictionary and instead wrap it. then we can check if people try and set reserved keys. but that would be a breaking change. let me know if u want an issue raise for v4 to make this change

@SimonCropp SimonCropp merged commit 4b52b7b into main Jun 7, 2022
@SimonCropp SimonCropp deleted the type-checking-in-Contexts-TryGetValue branch June 7, 2022 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattjohnsonpint mattjohnsonpint mattjohnsonpint approved these changes

@bruno-garcia bruno-garcia Awaiting requested review from bruno-garcia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@SimonCropp @mattjohnsonpint