Serialize addresses as strings #1692
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address properties on stack traces were previously being serialized to JSON as long integers, rather than in hex string format. For example,
"image_addr": 140734736058048instead of"image_addr": "0x7fff5bf346c0".While either format is allowed by the back end (handled in this function), most of the other Sentry SDKs are using the string format.
Specifically,
image_addrandsymbol_addrare represented as strings in the Java SDK. Passing events via serialization/deserialization between the two SDKs will fail unless they are strings here. (I'll be doing that in a future PR soon, when sending data between the managed and Android-native SDKs.)I've left the actual properties alone, as they are public and we don't need a breaking change.